Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvested Files - Several with 0 bytes #2221

Closed
raprasad opened this issue May 29, 2015 · 6 comments
Closed

Harvested Files - Several with 0 bytes #2221

raprasad opened this issue May 29, 2015 · 6 comments

Comments

@raprasad
Copy link
Contributor

raprasad commented May 29, 2015

Potential error. May be with source data

harvard_dataverse

@raprasad raprasad added this to the In Review milestone May 29, 2015
@mheppler mheppler changed the title several harvested files with 0 bytes Harvested Files - Several with 0 bytes Jan 27, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@scolapasta
Copy link
Contributor

Also md5.

Since these are harvested, we don't have this info, so we probably should hide this on the card.

mheppler added a commit that referenced this issue Feb 5, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 5, 2016

Added render logic to hide empty metadata fields for harvested files in the dataverse result cards.

This code was pushed to the "2221-harvested-file-cards" branch.

@mheppler
Copy link
Contributor

mheppler commented Feb 8, 2016

@kcondon - This was not tested locally, as I was not able to set up my local environment with harvested files.

@scolapasta scolapasta added this to the 4.2.4 milestone Feb 9, 2016
mheppler added a commit that referenced this issue Feb 9, 2016
@mheppler
Copy link
Contributor

mheppler commented Feb 9, 2016

Deleted old branch, created "2221-new-harvested-file-cards" branch and recommitted change to search-include-fragment due to 4.3 development code somehow getting mixed in.

@landreev
Copy link
Contributor

landreev commented Feb 9, 2016

OK, pushed my fix (for the broken dataset links in harvested file cards).
Git made me do a merge in the process... I seriously hope I didn't mess up this branch in the process.
@mheppler
@kcondon
Odum files are still showing as "unpublished". This is NOT a code error. It is something we fixed in the database - but we need to reindex all Odum datasets for it to take effect.

@mheppler
Copy link
Contributor

mheppler commented Feb 9, 2016

Just did a double-check on the latest version of search-include-fragment in this branch, and it looks like my code is still in there.

scolapasta added a commit that referenced this issue Feb 9, 2016
Harvested File card render logic to hide empty metadata fields [ref #2221]
@mheppler mheppler changed the title Harvested Files - Several with 0 bytes Harvested Files - Several with 0 bytes Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants