Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs for harvested datasets are not rendered properly. #2907

Closed
landreev opened this issue Feb 2, 2016 · 6 comments
Closed

URLs for harvested datasets are not rendered properly. #2907

landreev opened this issue Feb 2, 2016 · 6 comments
Assignees
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone

Comments

@landreev
Copy link
Contributor

landreev commented Feb 2, 2016

A side effect of the dataverse page optimizations in 4.2.2. And my penny-pinching with entity objects, trying not to instantiate anything except for what was strictly necessary.
As the end result, a URL pointing to a local dataset.xhtml is rendered, instead of a link to the remote location.
I'm marking it 4.3, but would be in favor of producing a production patch for this.

@landreev landreev added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: High labels Feb 2, 2016
@landreev landreev self-assigned this Feb 2, 2016
@landreev landreev added this to the 4.3 milestone Feb 2, 2016
@scolapasta scolapasta modified the milestones: 4.3, 4.2.4 Feb 4, 2016
@landreev
Copy link
Contributor Author

landreev commented Feb 5, 2016

I have a simple fix checked in, into the branch 2686-2907-bugfixpatch-424.
It's simple, or simplified in that, rather than fixing the card-rendering code in the SearchResultsFragment, to render the correct remote url, it was much easier to modify DatasetPage, to redirect to the original harvested URL (instead of issuing 404).
So the user still goes to the local dataset.xhtml, but gets redirected from there. It should be invisible to the user and the end result will be correct.

@landreev landreev assigned kcondon and unassigned landreev Feb 5, 2016
@landreev
Copy link
Contributor Author

landreev commented Feb 5, 2016

Once again, the branch name is 2686-2907-bugfixpatch-424
You'll need some harvested datasets in order to test that it's working now...
On a copy of prod. db perhaps?

@kcondon
Copy link
Contributor

kcondon commented Feb 8, 2016

This works for Odum and now Roper, now that the destination service was updated, but fails with 404 for ICPSR. Most likely an issue with the actual destination URL being outdated now, will check.

Spoke with Leonid, it is a problem. Will continue checking others, passing back to Leonid.

@kcondon kcondon assigned landreev and unassigned kcondon Feb 8, 2016
@landreev
Copy link
Contributor Author

landreev commented Feb 8, 2016

It is a local "404", so it is a lookup problem on our end.
Most likely because our DOI code expects to have another "/" in the authority, maybe? - Their authority has no "shoulder" - it's just "10.3886".
Looking into it.

landreev added a commit that referenced this issue Feb 8, 2016
@landreev landreev assigned kcondon and unassigned landreev Feb 8, 2016
@landreev
Copy link
Contributor Author

landreev commented Feb 8, 2016

Pushed a fix into the branch.

@kcondon
Copy link
Contributor

kcondon commented Feb 8, 2016

OK, works now. Closing.

@kcondon kcondon closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

3 participants