Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileMetadataIT.testJsonParserWithDirectoryLabels failing #6863

Closed
pdurbin opened this issue Apr 28, 2020 · 6 comments · Fixed by #6864 or #8168
Closed

FileMetadataIT.testJsonParserWithDirectoryLabels failing #6863

pdurbin opened this issue Apr 28, 2020 · 6 comments · Fixed by #6864 or #8168

Comments

@pdurbin
Copy link
Member

pdurbin commented Apr 28, 2020

FileMetadataIT.testJsonParserWithDirectoryLabels is failing for me locally as well as at https://jenkins.dataverse.org/job/IQSS-dataverse-develop/435/

kcondon added a commit that referenced this issue May 4, 2020
move makeSuperUser up to avoid "must be superuser" #6863
@scolapasta scolapasta reopened this May 3, 2021
@scolapasta
Copy link
Contributor

This test still is failing (at leas intermittently) so I'm reopening up this issue.

@scolapasta
Copy link
Contributor

scolapasta commented May 3, 2021

(Oh, I didn't realize the April date above was 2020, not 2021 (i.e. a year ago). Still not much noise here, so I think it's ok to track here.

@sekmiller
Copy link
Contributor

This is still failing via Jenkins in the Download All branch, though not for me locally in that branch.

@qqmyers
Copy link
Member

qqmyers commented May 3, 2021

Can using the first 8 chars of a UUID as the testName (line 44) cause issues? I.e. some char that isn't allowed in a dataverse name/alias?

@pdurbin
Copy link
Member Author

pdurbin commented May 3, 2021

@qqmyers yes, good call. It's probably the dv alias. If we switch to UtilIT.getRandomDvAlias() a "dv" will be prepended, making a valid dv alias (rather than all digits, occasionally).

pdurbin added a commit that referenced this issue Oct 20, 2021
(It's only sometimes an integer, of course, randomly.)

This was previously fixed for other tests in pull request #3898.
@pdurbin pdurbin self-assigned this Oct 20, 2021
@pdurbin pdurbin removed their assignment Oct 20, 2021
@pdurbin
Copy link
Member Author

pdurbin commented Oct 20, 2021

At standup I mentioned that #8165 failed because of this test and that the fix should be trivial. I went ahead and made pull request #8168.

Gold star for @qqmyers for mentioning above that it's probably the "integers aren't allowed in dataverse aliases" problem we fixed previously in pull request #3898.

kcondon added a commit that referenced this issue Oct 26, 2021
prevent test from failing because dv alias is an integer #6863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants