Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A quick fix for the search card for a harvested file: it should not t… #4787

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

landreev
Copy link
Contributor

@landreev landreev commented Jun 27, 2018

…ry to send the user to the file page; it should always redirect to the dataset-level remote page at the original source of the harvested object. (#4288)

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

…ry to send the user to the file page; it should always redirect to the dataset-level remote page at the original source of the harvested object. (#4288)
Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL logic change looks logical to me. Tested on production patch and confirmed it's fixed there. Moving to QA.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Approved.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 13.26% when pulling d4f562a on 4288-no-file-page-for-harvested-files into 2c41710 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants