Harvester improvements. #6087
Merged
Harvester improvements. #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the issue with transaction scope when deleting harvested records, per OAI instructions; plus some cosmetic issues and minor optimizations. (#3268)
mheppler
reviewed
Aug 13, 2019
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DestroyDatasetCommand.java
Outdated
Show resolved
Hide resolved
…/dataverse into 3268-harvester-improvements
|
Can one of the admins verify this patch? |
pdurbin
approved these changes
Aug 16, 2019
| public void deleteHarvestedDataset(Dataset dataset, DataverseRequest request, Logger hdLogger) { | ||
| // Purge all the SOLR documents associated with this client from the | ||
| // index server: | ||
| indexService.deleteHarvestedDocuments(dataset); |
There was a problem hiding this comment.
Should this indexing operation be moved to "on success"?
| @@ -315,8 +309,7 @@ public void doHarvest(DataverseRequest dataverseRequest, Long harvestingClientId | |||
|
|
|||
|
|
|||
|
|
|||
| @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED) | |||
| public Long processRecord(DataverseRequest dataverseRequest, Logger hdLogger, PrintWriter importCleanupLog, OaiHandler oaiHandler, String identifier, MutableBoolean recordErrorOccurred, MutableLong processedSizeThisBatch, List<String> deletedIdentifiers) { | |||
| private Long processRecord(DataverseRequest dataverseRequest, Logger hdLogger, PrintWriter importCleanupLog, OaiHandler oaiHandler, String identifier, MutableBoolean recordErrorOccurred, MutableLong processedSizeThisBatch, List<String> deletedIdentifiers, Date dateStamp) { | |||
There was a problem hiding this comment.
I'm curious why "TransactionAttributeType.NOT_SUPPORTED" has been removed. I'm not saying this is a problem, I'm just a little turned around about why this change is being made.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue with transaction scope when deleting harvested records, per OAI instructions;
plus some cosmetic issues and minor optimizations. (#3268)
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist