only show email portion system email via Harvesting #3619 #6513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Avoids OAI-PMH validation errors like this:
In my local testing, before making this pull request, I was seeing output like this...
<adminEmail>Support2 <[email protected]></adminEmail>
... from http://localhost:8080/oai?verb=Identify
Which issue(s) this PR closes:
Closes #3619
Special notes for your reviewer:
Suggestions on how to test this:
If you do something like this...
curl -X PUT -d "Support2 [email protected]" http://localhost:8080/api/admin/settings/:SystemEmail
... and then stop and start Glassfish (required to see the change, apparently) and then look for "adminEmail in the output of http://localhost:8080/oai?verb=Identify (or equivalent for your server) you should only see the email portion ([email protected]) of :SystemEmail, without the "personal name" (Support2).
To test if Dataverse validates in terms of OAI-PMH, I'd suggest using http://oval.base-search.net where the screenshot above comes from.
Does this PR introduce a user interface change?:
No.
Is there a release notes update needed for this change?:
Probably not worth it.
Additional documentation:
I put a line in the guides, the section on setting up a harvesting server.