Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only show email portion system email via Harvesting #3619 #6513

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 13, 2020

What this PR does / why we need it:

Avoids OAI-PMH validation errors like this:

65978606-fff89880-e441-11e9-9f58-5f19382163da

In my local testing, before making this pull request, I was seeing output like this...

<adminEmail>Support2 &lt;[email protected]&gt;</adminEmail>

... from http://localhost:8080/oai?verb=Identify

Which issue(s) this PR closes:

Closes #3619

Special notes for your reviewer:

Suggestions on how to test this:

If you do something like this...

curl -X PUT -d "Support2 [email protected]" http://localhost:8080/api/admin/settings/:SystemEmail

... and then stop and start Glassfish (required to see the change, apparently) and then look for "adminEmail in the output of http://localhost:8080/oai?verb=Identify (or equivalent for your server) you should only see the email portion ([email protected]) of :SystemEmail, without the "personal name" (Support2).

To test if Dataverse validates in terms of OAI-PMH, I'd suggest using http://oval.base-search.net where the screenshot above comes from.

Does this PR introduce a user interface change?:

No.

Is there a release notes update needed for this change?:

Probably not worth it.

Additional documentation:

I put a line in the guides, the section on setting up a harvesting server.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.504% when pulling e5d2ee2 on 3619-harvesting-admin-email into dcf0b48 on develop.

@kcondon
Copy link
Contributor

kcondon commented Jan 15, 2020

This fixes the angle bracket in systememail issue. Test data should be: curl -X PUT -d "Support2 [email protected]" http://localhost:8080/api/admin/settings/:SystemEmail

My test env does not validate using the specified service but that is outside the scope of this ticket:

Screen Shot 2020-01-15 at 1 45 18 PM

@kcondon kcondon self-assigned this Jan 15, 2020
@kcondon kcondon merged commit ee91ec7 into develop Jan 15, 2020
@kcondon kcondon deleted the 3619-harvesting-admin-email branch January 15, 2020 18:48
@djbrooke djbrooke added this to the 4.19 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adminEmail field invalid in OAI-PMH Identify response
5 participants