Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typo after running a harvesting client from Bundle.properties #6987. #6988

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Remove typo after running a harvesting client from Bundle.properties #6987. #6988

merged 1 commit into from
Jun 22, 2020

Conversation

JingMa87
Copy link
Contributor

What this PR does / why we need it: It fixes a typo in the UI

Which issue(s) this PR closes: #6987

Closes #6987

Special notes for your reviewer: Super simple fix

Suggestions on how to test this: Make a harvesting client and run it. When it's done you'll see a message pop up.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Super small change.

Is there a release notes update needed for this change?: Don't think so.

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.562% when pulling 576b060 on JingMa87:6987-run-harvest-typo into 4c05181 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you, @JingMa87 ! 🚀 🎉 💯

@JingMa87
Copy link
Contributor Author

@pdurbin Hey Philip, it says some checks were not successful. Is there something I can do to fix it or do I leave the rest of the process up to you guys?

@pdurbin
Copy link
Member

pdurbin commented Jun 17, 2020

@JingMa87 we can take it from here. Please forgive us, but we know about these failing tests and plan to fix them up before we release Dataverse 5.

@kcondon kcondon self-assigned this Jun 22, 2020
@kcondon kcondon merged commit 30ede65 into IQSS:develop Jun 22, 2020
@JingMa87 JingMa87 deleted the 6987-run-harvest-typo branch June 22, 2020 20:08
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo after successfully running a harvesting client
5 participants