7431 fixing invalid oai pmh response #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
approved these changes
Jun 29, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The ListRecords OAI-PMH response contains XML prolog for each records, which makes the XML invalid.
Which issue(s) this PR closes:
Closes #7431
Special notes for your reviewer: ListRecords did not had any integration tests, now I added some.
Suggestions on how to test this: It extends the integration tests in
HarvestingServerIT.testOaiFunctionality()method. You can also test it via checking the URL https://localhost:8080/oai?verb=ListRecords&metadataPrefix=Datacite in a browser. (Note: there might be other XML issues independent from this one, e.g. the dataverse-sample-data project creates dataset which has a '&' character in a field, and it is not escaped into '&' as expected.)Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: It might be mention that this issue has been fixed and it improves the interoperability of Dataverse, since this issue breaks not just the browser display, but triggers and error in the XML processors of the harvesters.
Additional documentation: no