-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
41 add auth to harvest api #8106
Conversation
StringReader rdr = new StringReader(jsonBody); | ||
|
||
try( JsonReader jrdr = Json.createReader(rdr) ) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[reviewdog] reported by reviewdog 🐶
'{' at column 2 should be on the previous line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK bot, point to you.
This reverts commit 9a809392f2f12638da98d35eb86a3b8eab6234d4.
@sekmiller I'm going to rerun the tests on this issue, just seeing if it was an intermittent failure |
(updating from develop to rerun the tests) |
OK! Tests pass. I'll unassign myself so that someone can review this. |
One quick thing is that the docs don't built, even though it says "all checks have passed" above. |
I wrote these guides, so I broke them. I will fix. |
having trouble with create set curl -H X-Dataverse-key:xxxx-yyyy-zzzz-aaaa -X POST "http://localhost:8080/api/harvest/server/oaisets/" --upload-file harvestset1.json |
tested endpoints, work as expected, slight doc issue with curved " chars in examples not working when cut and paste. |
My bad on the docs @kcondon @sekmiller - should be OK now. |
What this PR does / why we need it: The Delete Harvesting set api did not require any credentials. To mimic the ui super user permissions have been added. Also the modify harvesting set api end point had not been implemented so that was completed. And finally all of the Manage Harvesting sets apis were documented as they had not been previously.
Which issue(s) this PR closes:
Closes # https://github.com/IQSS/dataverse-security/issues/41
and closes #4514 Document Harvesting set endpoints
Special notes for your reviewer: There was also and endpoint for "/datasets" which returns an empty string. It's not clear what the intended response is, possibly a count of datasets that would be harvested given the definition. Without a clear intent I left it as I found it.
Suggestions on how to test this: verify that the endpoints work as documented and that a non-super user may not create, modify or delete a harvesting set.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?:
Additional documentation: