Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Support for older versions of Julia 1.10 and 1.11 #1623

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

mtfishman
Copy link
Member

This circumvents an issue in older versions of Julia 1.10 and 1.11 that made it so that the latest versions of NDTensors.jl/ITensors.jl couldn't be installed, caused by how we have some of our package extensions were configured. Basically, some package extensions depend on TypeParamaterAccessors.jl, but so does the main NDTensors.jl package, so TypeParamaterAccessors.jl is both a dependency and a weak dependency, and in older version of Julia I couldn't find a good way to handle that situation (which I think basically was a bug in the package system in older versions of Julia 1.10 and 1.11 but the origin of the issue is hard to track down). Now, I am using NDTensors.TypeParamaterAccessors in the package extensions, so it is no longer seen as a dependency of the package extensions and can just be handled as a normal dependency of the NDTensors.jl package.

This issue has been brought up a few times recently: #1618, #1620, https://itensor.discourse.group/t/typeparameteraccessors-not-found-error-on-julia-v-1-10-0/2260.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (b5eeb94) to head (d39806b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1623   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files          64       64           
  Lines        5083     5083           
=======================================
  Hits         4038     4038           
  Misses       1045     1045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit fb858d1 into main Feb 22, 2025
15 checks passed
@mtfishman mtfishman deleted the NDTensors_support_older_julia_versions branch February 22, 2025 17:07
@emstoudenmire
Copy link
Collaborator

Updated on itensor.org News page too:
https://itensor.org/news/25_02_20_julia_versions.html

@mtfishman
Copy link
Member Author

Good idea, thanks @emstoudenmire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants