Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve git status items with icons and tag name #154

Closed
bric3 opened this issue May 12, 2021 · 8 comments
Closed

Improve git status items with icons and tag name #154

bric3 opened this issue May 12, 2021 · 8 comments
Labels
🌊 enhancement New feature or request
Milestone

Comments

@bric3
Copy link

bric3 commented May 12, 2021

Is your feature request related to a problem? Please describe

I am using the lean config with icon full mode, yet git item does not display any (neither git, or github icon). Also I noted that git item could be improved as well when git repo is on a tag.

powerline10k :

  ~/opensource/one-nio   master ❯
  ~/opensource/one-nio  #1.3.1 ❯

image

image

fish:

  ~/opensource/one-nio master ❯ git co 1.3.1 &> /dev/null
  ~/opensource/one-nio 0b9c0ab ❯

image

Describe the solution you'd like

In the images above I am showing what powerline 10k is doing, I think this should be what this status should aim for.

Additional context

@IlanCosman
Copy link
Owner

IlanCosman commented May 12, 2021

There, tags will show up nicely in Tide v5, whenever that comes out.

I don't want to add the git/github logo though, for performance reasons. git config --get remote.origin.url takes 8ms by itself, and we'd have to parse it to see whether it was a github url. That's a steep performance and code complexity penalty for a tiny improvement in functionality.

@bric3
Copy link
Author

bric3 commented May 16, 2021

@IlanCosman Cool thank for the update, I get the performance reason to read the remote url, but why not a default git icon ?

Also shouldn't the async rendering somewhat moderate this performance penalty.

@IlanCosman
Copy link
Owner

Sure, I can do a default git icon.

And yes, async means that a 10ms delay in git repos isn't a big deal, especially when git status takes most of the time. But it's still a small cost, and a moderate cost in code complexity, that I think isn't worth it.

IlanCosman added a commit that referenced this issue May 16, 2021
@bric3
Copy link
Author

bric3 commented May 16, 2021

But it's still a small cost, and a moderate cost in code complexity, that I think isn't worth it.

Fair enough

@luxalpa
Copy link

luxalpa commented Oct 1, 2021

Do you think it's possible to make  the standard git icon instead of using the placeholder? It's being used in the screenshots and it was disappointing to see that it didn't show the icon when using the theme :(

@IlanCosman
Copy link
Owner

@luxalpa That gif shows Starship first, a separate popular prompt. The gif is meant to show that Starship is slower than Tide in large git repositories.

@luxalpa
Copy link

luxalpa commented Oct 1, 2021

aw, still I think an icon for git would be much nicer than having just text.

@IlanCosman
Copy link
Owner

It actually is a nerd font icon: 
It does look like text though 😂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌊 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants