fix: s5cmd sync logic #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when dirTemplate is none, hierarchy is constructed using sql CONCAT statement as using downloadDir directly faced issues with duckdb parsing a query index_crdc_series_uuid column is added to validation query, as this uuid is helpful for calculating required downloading w/ s5cmd sync improve efficiency by reducing the number of columns read when using prior index remove the dedicated query to build paths and instead construct download paths direcly in the validation query return one additional output as dataframe from validation function which will be passed to s5cmd_run. This df is helpful when s5cmd sync is used and download size needs to be calculated. Eliminates redundancy The dataframe contains "index_crdc_series_uuid", "s5cmd_cmd", "series_size_MB", "path" columns The above df is passed as s5cmd_sync_helper_df in _s5cmd_run method simplify _parse_s5cmd_sync_output_and_generate_synced_manifest method definition utilizing the s5cmd_sync_helper_df test manifest is edited to pick the 5 smallest series from previous index
vkt1414
force-pushed
the
feat-add-metadata-for-series-not-in-latest-index-for-idc-2
branch
from
da9e95a to
95d555f
Compare
fedorov
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completes #100
fixes and improves logic of s5cmd sync download by utilizing validation results
picks 5 smallest series from previous idc versions
tests prior versions data rigorosly with all combinations of optional parameters
may be better to create a new issue to support this #100 (comment). So far I do not know an 'elegant' way to support it