Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: use trim to remove any extraneous spaces while parsing s3 url in manifest #116

Merged
merged 2 commits into from
Aug 21, 2024
Merged

BUG: use trim to remove any extraneous spaces while parsing s3 url in manifest #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94be418
BUG: use trim to remove any extraneous spaces while parsing s3 url in…
vkt1414 Aug 21, 2024
206118c
ENH: simplify s3_url extraction
fedorov Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion idc_index/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ def _validate_update_manifest_and_get_download_size(
SELECT
manifest_cp_cmd,
REGEXP_EXTRACT(manifest_cp_cmd, '(?:.*?\\/){{3}}([^\\/?#]+)', 1) AS manifest_crdc_series_uuid,
REGEXP_REPLACE(regexp_replace(manifest_cp_cmd, 'cp ', ''), '\\s[^\\s]*$', '') AS s3_url,
REGEXP_EXTRACT(manifest_cp_cmd, 's3://\\S+') AS s3_url,
FROM
manifest_df )
SELECT
Expand Down
Loading