enh: add double quotes before paths so spaced paths can work #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, this makes sense - we did the same for the portal, but I didn't connect the dots... 
Correction - not quite the same :-D |
fedorov
reviewed
Jun 6, 2024
vkt1414
force-pushed
the
enh-support-spaced-paths
branch
2 times, most recently
from
a91449c to
15709cb
Compare
fedorov
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever a download path consists of spaces, s5cmd command does not work.
But to force it, we must include the path containing spaces in double quotes. The issue was first encountered in SlicerIDCBrowser. ImagingDataCommons/SlicerIDCBrowser#39
This PR will fix ImagingDataCommons/SlicerIDCBrowser#39