enh: add zero parameter download cli

[fedorov]

This should address most common usage scenario.

Follow up on #33.

[vkt1414]

I do not see a reason why we should not validate every value passed on. This may go back to the philosophical debate of whether we inform the user for passing some invalid values. In my opinion, we must. So I would change this to..

else:
    # Split the input string and filter out any empty values
    item_ids = [item for item in generic_argument.split(",") if item]

    if not item_ids:
        logger_cli.error("No valid IDs provided.")
        raise ValueError("No valid IDs provided.")

    index_df = client.index

    def check_and_download(column_name, item_ids, download_dir, kwarg_name):
        matches = index_df[column_name].isin(item_ids)
        matched_ids = index_df[column_name][matches].tolist()
        if not matched_ids:
            return False
        unmatched_ids = list(set(item_ids) - set(matched_ids))
        if unmatched_ids:
            raise ValueError(f"Partial match for {column_name}: matched {matched_ids}, unmatched {unmatched_ids}")
        logger_cli.debug(f"Downloading from {column_name}")
        client.download_from_selection(**{kwarg_name: matched_ids, 'downloadDir': download_dir})
        return True

    # Check for matches in each column and download if matches found
    if not (
        check_and_download("collection_id", item_ids, download_dir, 'collection_id') or
        check_and_download("PatientID", item_ids, download_dir, 'patientId') or
        check_and_download("StudyInstanceUID", item_ids, download_dir, 'studyInstanceUID') or
        check_and_download("SeriesInstanceUID", item_ids, download_dir, 'seriesInstanceUID')
    ):
        logger_cli.error("None of the values passed matched any of the four UUIDs: collection_id, PatientID, StudyInstanceUID, SeriesInstanceUID.")
        raise ValueError("None of the values passed matched any of the four UUIDs: collection_id, PatientID, StudyInstanceUID, SeriesInstanceUID.")

If you think it's an overkill, I would at least add a raise exception at the end to catch if the first value passed does not match any of the four UUIDs

[fedorov]

That's a good idea. Can you add this in a commit?

I do not like the exception though, I don't think it is helpful. I think console error is sufficient.

[vkt1414]

I do not know what a console error is. Also what do you not like about the exception message? Isn't it exactly what we trying to do and failing if it reaches the last else condition?

[vkt1414]

If I understand correctly, you simply wanted to remove raising exceptions but warn the user from logger? If so, I made the change now.

[fedorov]

I do not know what a console error is.

I mean logger error.

Also what do you not like about the exception message? Isn't it exactly what we trying to do and failing if it reaches the last else condition?

Raising exception aborts the command line execution and prints execution stack. I see zero benefit in showing execution stack to the user. It is sufficient to let them know none of the identifiers was matched.