Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flutter compatibility 3.29 #558

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kholood-ea
Copy link
Contributor

@kholood-ea kholood-ea commented Mar 6, 2025

Description of the change

fix build issue with flutter 3.29

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JiraID:INSD-13145

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Mar 6, 2025

Coverage Report

Label Coverage Status
Dart 80.4%

Generated by 🚫 dangerJS against 824d2ea

@kholood-ea kholood-ea closed this Mar 6, 2025
@kholood-ea kholood-ea deleted the fix/flutter-compatibility-3.29 branch March 6, 2025 11:31
@kholood-ea kholood-ea restored the fix/flutter-compatibility-3.29 branch March 6, 2025 11:33
@kholood-ea kholood-ea reopened this Mar 6, 2025
@MaciejCaputa
Copy link

MaciejCaputa commented Mar 7, 2025

Hi, I have used the first commit of this PR i.e. b6b761059288beef7121d6b3d043f90702ecc342 and added it to our pubspec:

  instabug_flutter:
    git:
      url: "https://github.com/Instabug/Instabug-Flutter/"
      ref: "61227a346da309037a16aa4fdbf973f5fd35961b"

Following that I have added a script which runs Pigeons.

I confirm that it works. It would be much easier for us if it would merged but nothleless thank you for helping.

Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kholood-ea Could you please check the failed CI jobs? Both iOS and Android E2E jobs are failing in three tests, and it doesn’t appear to be due to flaky tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we committing an empty file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not empty but I don't know why it shows in the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants