-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flutter compatibility 3.29 #558
base: master
Are you sure you want to change the base?
Conversation
Hi, I have used the first commit of this PR i.e.
Following that I have added a script which runs Pigeons. I confirm that it works. It would be much easier for us if it would merged but nothleless thank you for helping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kholood-ea Could you please check the failed CI jobs? Both iOS and Android E2E jobs are failing in three tests, and it doesn’t appear to be due to flaky tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we committing an empty file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not empty but I don't know why it shows in the diff
Description of the change
fix build issue with flutter 3.29
Type of change
Related issues
JiraID:INSD-13145
Checklists
Development
Code review