Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpctl should provide cmake config files and install them #851

Open
diptorupd opened this issue Jun 10, 2022 · 2 comments
Open

dpctl should provide cmake config files and install them #851

diptorupd opened this issue Jun 10, 2022 · 2 comments
Assignees
Labels
cmake Issue pertaining to CMake enhancement New feature or request

Comments

@diptorupd
Copy link
Contributor

The FindDpctl.cmake is not installed as part of the conda package nor do we currently provide a DpctlConfig.cmake file. The result is that dpctl cannot be found by external cmake projects.

CMake Error at CMakeLists.txt:7 (find_package):
By not providing "FindDpctl.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Dpctl", but
CMake did not find one.

Could not find a package configuration file provided by "Dpctl" with any of
the following names:

DpctlConfig.cmake
dpctl-config.cmake

Add the installation prefix of "Dpctl" to CMAKE_PREFIX_PATH or set
"Dpctl_DIR" to a directory containing one of the above files. If "Dpctl"
provides a separate development package or SDK, be sure it has been
installed.

@oleksandr-pavlyk
Copy link
Collaborator

I think this would be closed by #853.

With #853 all one needs to do python setup.py develop -- -DPDCTL_MODULE_PATH=$(python -m dpctl --cmakedir) to build external package which uses dpctl via find_package(dpctl) in their CMakeLists.txt.

@oleksandr-pavlyk
Copy link
Collaborator

No, we should create dpctlConfig.cmake and make sure it installed in $PREFIX/share/cmake/dpctl/dpctlConfig.cmake.

Thus would allow find_package(Dpctl REQUIRED) to work without setting any additional module path variables.

@oleksandr-pavlyk oleksandr-pavlyk self-assigned this Sep 15, 2023
@oleksandr-pavlyk oleksandr-pavlyk added enhancement New feature or request cmake Issue pertaining to CMake labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Issue pertaining to CMake enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants