Install cmake scripts #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indended usage of the main module is
```bash
python -m dpctl --includes # prints include flags for dpctl headers
```
```bash
python -m dpctl --cmakdir # prints directory to be used as DPCTL_ROOT \
# for cmake to find dpctl package
```
```bash
python -m dpctl --library # prints linker flags for linking \
# to SyclInterface library
```
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/853/index.html |
|
With this change building a Python extension using scikit-build with open-source DPC++ from nightly sycl bundle becomes possible by doing IntelDPCPP_DIR=$(python -m dpctl --cmakedir) CXX=$(which clang++) python setup.py develop |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
1 task
oleksandr-pavlyk
added a commit
that referenced
this pull request
Jul 25, 2022
expanded changelog with work from gh-853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
.cmakescripts needed for CMake to finddpctlwere not installed intosite-packages/dpctl. It can now be found insite-packages/dpctl/resources/cmake.CMakeLists.txtwas modified to copy*.cmakefiles fromcmake/todpctl/resources/cmake.MANIFEST.infile was modified to ensure*.cmakefiles are copied over.__main__.pywas added to allow scripts to getpython -m dpctl --includes- prints include flags for compiling source using dpctl's include filespython -m dpctl --library- prints linker flags that needs to link to SyclInterface librarypython -m dpctl --cmakdir- prints the folder where cmake scripts are which you setDPCTL_ROOTto for cmake to be able to executefind_packages(dpctl).__main__works correctlyHave you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you made sure that new changes do not introduce compiler warnings?
Also modified vendored
IntelDPCPPConfig.cmaketo align it with that included in oneAPI DPC++ compiler layout.