Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type "Dword pointer" reverts to "graphics" after saving/loading project #62

Closed
ChristopheF opened this issue Sep 1, 2021 · 2 comments

Comments

@ChristopheF
Copy link

How to reproduce:
Open a project
Mark some bytes as "Dword pointer" type
Save the project and close DistinGUIsh
Load the project
The bytes are now marked as "Graphics" instead of "Dword pointer".

@binary1230
Copy link
Collaborator

sorry about that, was a really silly mistake. latest release should have that fixed up for you

@ChristopheF
Copy link
Author

Thanks for the fix!

binary1230 added a commit to binary1230/DiztinGUIsh that referenced this issue Dec 12, 2021
- fixes IsoFrieze#62
- both 'Dword ptr' and 'Graphics' were using the character 'G' for their compressed encoding in the XML, must be unique
- I have... no idea why I didn't just use a Dictionary here in the first place. switched to that to enforce unique keys.
- change char for 32bit dword point from 'G' (conflict) to 'H' (unique)

(cherry picked from commit f1ce061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants