Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right diagonal button bottom vs top #27

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JLambertazzo
Copy link
Owner

Was wondering about this and wanted to get some review. Diagonal arrow on the right side of the screen wastes space, especially bad on mobile phones as it really shrinks image previews. But moving it to the bottom may hide it on desktop screens which are wider but shorter.

Any thoughts on this?

@JLambertazzo JLambertazzo self-assigned this Feb 26, 2024
@JLambertazzo JLambertazzo marked this pull request as draft February 26, 2024 05:57
@JLambertazzo
Copy link
Owner Author

Screenshot_20240226-005125.png

Screenshot_20240226-005138.png

Here are the two examples on mobile

@cviebrock
Copy link
Collaborator

I agree that there is wasted space. However, I think this is more to do with the size of the arrows, the padding around them, and the table spacing in general.

Having it in the top-right also gives a symmetry to the entire bingo card.

Of course, this is all subjective. :)

Screen Shot 2024-02-26 at 10 36 03 AM

@cviebrock
Copy link
Collaborator

I just checked in dev inspector. On the new design, even with the top-right diagonal button, the images are 50x50px on an iPhone SE (screen width 375px). On the old design, they are 35px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants