feat(jans-cli-tui): update to prompt_toolkit v3 #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossdhaval
added
kind-dependencies
v2 is essentially unmaintained since last release was in 2019 Signed-off-by: Dāvis Mosāns <[email protected]>
|
Added DCO. |
devrimyatar
approved these changes
Feb 1, 2024
moabu
approved these changes
Feb 1, 2024
devrimyatar
added a commit
that referenced
this pull request
Feb 3, 2024
This reverts commit dcc3abd.
devrimyatar
added a commit
that referenced
this pull request
Feb 3, 2024
This reverts commit dcc3abd. Signed-off-by: Mustafa Baser <[email protected]>
moabu
pushed a commit
that referenced
this pull request
Feb 3, 2024
* Revert "feat(jans-cli-tui): update to prompt_toolkit v3 (#7491)" This reverts commit dcc3abd. Signed-off-by: Mustafa Baser <[email protected]> * Revert "fix(jans-linux-setup): update prompt-toolkit 3.0.43 (#7604)" This reverts commit e35963f. Signed-off-by: Mustafa Baser <[email protected]> --------- Signed-off-by: Mustafa Baser <[email protected]>
yuriyz
pushed a commit
that referenced
this pull request
Nov 7, 2024
v2 is essentially unmaintained since last release was in 2019 Signed-off-by: Dāvis Mosāns <[email protected]> Co-authored-by: Mohammad Abudayyeh <[email protected]> Co-authored-by: Devrim <[email protected]> Former-commit-id: dcc3abd
yuriyz
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Revert "feat(jans-cli-tui): update to prompt_toolkit v3 (#7491)" This reverts commit c7f1f97 [formerly dcc3abd]. Signed-off-by: Mustafa Baser <[email protected]> * Revert "fix(jans-linux-setup): update prompt-toolkit 3.0.43 (#7604)" This reverts commit 13fe5a6 [formerly e35963f]. Signed-off-by: Mustafa Baser <[email protected]> --------- Signed-off-by: Mustafa Baser <[email protected]> Former-commit-id: b3f6834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
prompt_toolkit v2 is essentially unmaintained since last release was in 2019. This PR switches implementation to prompt_toolkit v3
Implementation Details
See https://python-prompt-toolkit.readthedocs.io/en/master/pages/upgrading/3.0.html
Test and Document the changes