Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-cli-tui): keybindings <d> and <delete> to delete item, <v> to view item #7729

Merged
merged 3 commits into from
Feb 16, 2024
Merged

feat(jans-cli-tui): keybindings <d> and <delete> to delete item, <v> to view item #7729

merged 3 commits into from
Feb 16, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #7717

@devrimyatar devrimyatar added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-cli-tui Component affected by issue or PR labels Feb 14, 2024
@devrimyatar devrimyatar requested review from yuriyz and pujavs February 14, 2024 18:11
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Feb 14, 2024
@yuriyz yuriyz enabled auto-merge (squash) February 14, 2024 20:37
@devrimyatar devrimyatar requested a review from yurem February 15, 2024 08:54
@yuriyz yuriyz merged commit 5ce3c5e into main Feb 16, 2024
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-cli-tui-7717 branch February 16, 2024 07:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ossdhaval
Copy link
Contributor

@devrimyatar I found this documentation to be relevant to this PR. Can you see if the document needs to be updated as well?

@devrimyatar
Copy link
Contributor Author

@ossdhaval Yes documentation needs to be updated accordingly

devrimyatar added a commit that referenced this pull request Feb 27, 2024
@devrimyatar @yuriyz
feat(jans-cli-tui): keybindings <d> and <delete> to delete item, <v> …
91907a9 
…to view item (#7729)

Signed-off-by: Mustafa Baser <[email protected]>
Co-authored-by: YuriyZ <[email protected]>
Signed-off-by: Mustafa Baser <[email protected]>
yuriyz added a commit that referenced this pull request Nov 7, 2024
@devrimyatar @yuriyz
feat(jans-cli-tui): keybindings <d> and <delete> to delete item, <v> …
1c4f271 
…to view item (#7729)

Signed-off-by: Mustafa Baser <[email protected]>
Co-authored-by: YuriyZ <[email protected]>
Former-commit-id: 5ce3c5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@pujavs pujavs pujavs approved these changes

@yurem yurem Awaiting requested review from yurem

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-cli-tui): del --> d to delete
5 participants
@devrimyatar @ossdhaval @yuriyz @pujavs @mo-auto