-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(jans-pycloudlib): handle google secret versioning #7971
Conversation
Signed-off-by: iromli <[email protected]>
…oogle secrets Signed-off-by: iromli <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7971 +/- ##
=======================================
Coverage ? 60.41%
=======================================
Files ? 36
Lines ? 3165
Branches ? 0
=======================================
Hits ? 1912
Misses ? 1253
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…oogle configuration Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
Signed-off-by: iromli <[email protected]>
|
|
|
|
Signed-off-by: iromli <[email protected]>
I do have a concern regarding possible leftover versions from race conditions or failed operations. I'm thinking we add a check in certmanager to run it after key rotation which would make sure old versions are cleaned up and only the last CN_GOOGLE_SECRET_MAX_VERSIONS are kept |
It is taken care by lower-level jans-pycloudlib google wrapper. |
|
* perf(jans-pycloudlib): handle google secret versioning Signed-off-by: iromli <[email protected]> * refactor(jans-pycloudlib): add configurable max active versions for google secrets Signed-off-by: iromli <[email protected]> * refactor(jans-pycloudlib): add configurable max active versions for google configuration Signed-off-by: iromli <[email protected]> * refactor(jans-pycloudlib): update google secret only if values changed Signed-off-by: iromli <[email protected]> * refactor(jans-pycloudlib): remove code smells Signed-off-by: iromli <[email protected]> * feat: keep certain number of google secret versions Signed-off-by: iromli <[email protected]> * docs(kubernetes): add section mentioning google secret versions Signed-off-by: iromli <[email protected]> --------- Signed-off-by: iromli <[email protected]> Co-authored-by: Mohammad Abudayyeh <[email protected]> Former-commit-id: 254b1a5
Prepare
Description
Target issue
closes #7944
Implementation Details
Test and Document the changes