Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work for private repos #35

Open
3 tasks
JasonEtco opened this issue Mar 17, 2018 · 2 comments
Open
3 tasks

Work for private repos #35

JasonEtco opened this issue Mar 17, 2018 · 2 comments

Comments

@JasonEtco
Copy link
Owner

JasonEtco commented Mar 17, 2018

Currently, ci-reporter will not work for private repositories because the CI providers that private repos use require an API key for private builds. Here are the things that need to happen for private repo support to be possible:

  • A UI (or some other method) to encrypt API keys
  • Store encrypted API keys in the .github/ci-reporter.yml file
  • Use those keys in API calls to CI providers

To be clear, I do not want to resort to using a database for these keys. There is too much overhead involved, and I'd like to nail down a good pattern for encrypting/storing keys in repositories since it'll have implications for many more apps.

@jpike88
Copy link

jpike88 commented May 17, 2018

I'm all for this, it doesn't need to be complicated either. Need it for CodeBuild. Is anyone planning on doing this?

@Dombo
Copy link

Dombo commented Dec 3, 2018

What would be an appropriate key to use to encrypt these secrets - the private key that the GitHub app has?

I investigated if Circle has a tidy way to generate an API key with a limited set of permissions but it does not so that would need to be communicated to the user, likely during the install & redirect phase of application install.

I think short of GitHub providing a store for secret material the best we can do is your prescribed approach.

What's the consensus between:

A) showing the user the encrypted key and asking them to commit it to config.yml

B) granting the application repository write permissions to abstract away the additional install step outlined in A?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants