Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do nothing in private repos #4

Closed
JasonEtco opened this issue Dec 23, 2017 · 3 comments
Closed

Do nothing in private repos #4

JasonEtco opened this issue Dec 23, 2017 · 3 comments

Comments

@JasonEtco
Copy link
Owner

Because of CI permissions, if the repo is private then the ci-reporter won't be able to access the service's APIs for the builds. There should be a check in the status event handler to prevent acting on a private repo, which would incur errors.

@j-f1
Copy link

j-f1 commented Dec 23, 2017

You could ask the user to run travis token --pro and give the app the result.

@JasonEtco
Copy link
Owner Author

JasonEtco commented Dec 23, 2017

Yep! But then I'll need to keep track of the tokens, which means I'll likely need a database to store them, and that's more than I want to do right now. I may have to anyway, CircleCI may always need a token, but if I can avoid a database that'd be nice.

@JasonEtco
Copy link
Owner Author

Closing in favor of #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants