Table.id is not in record set #1341

JetBrains · Sep 13, 2021 · 9c0d295 · 9c0d295
1 parent 7c1b871
commit 9c0d295
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 2 deletions.
diff --git a/exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/InsertStatement.kt b/exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/statements/InsertStatement.kt
@@ -41,7 +41,7 @@ open class InsertStatement<Key : Any>(val table: Table, val isIgnore: Boolean =
                 }
             }
 
-            val firstAutoIncColumn = autoIncColumns.firstOrNull()
+            val firstAutoIncColumn = autoIncColumns.firstOrNull { it.autoIncColumnType != null } ?: autoIncColumns.firstOrNull()
             if (firstAutoIncColumn != null || returnedColumns.isNotEmpty()) {
                 while (rs?.next() == true) {
                     val returnedValues = returnedColumns.associateTo(mutableMapOf()) { it.first to rs.getObject(it.second) }
@@ -147,7 +147,7 @@ open class InsertStatement<Key : Any>(val table: Table, val isIgnore: Boolean =
     override fun prepared(transaction: Transaction, sql: String): PreparedStatementApi = when {
         // https://github.com/pgjdbc/pgjdbc/issues/1168
         // Column names always escaped/quoted in RETURNING clause
-        autoIncColumns.isNotEmpty() && currentDialect is PostgreSQLDialect ->
+         autoIncColumns.isNotEmpty() && currentDialect is PostgreSQLDialect ->
             transaction.connection.prepareStatement(sql, true)
 
         autoIncColumns.isNotEmpty() ->

diff --git a/...c/test/kotlin/org/jetbrains/exposed/sql/tests/shared/entities/EntityBugsRegressionTest.kt b/...c/test/kotlin/org/jetbrains/exposed/sql/tests/shared/entities/EntityBugsRegressionTest.kt
@@ -0,0 +1,59 @@
+@file: Suppress("MatchingDeclarationName", "Filename")
+package org.jetbrains.exposed.sql.tests.shared.entities
+
+import org.jetbrains.exposed.dao.EntityClass
+import org.jetbrains.exposed.dao.IntEntity
+import org.jetbrains.exposed.dao.IntEntityClass
+import org.jetbrains.exposed.dao.id.EntityID
+import org.jetbrains.exposed.dao.id.IdTable
+import org.jetbrains.exposed.sql.Column
+import org.jetbrains.exposed.sql.tests.DatabaseTestsBase
+import org.jetbrains.exposed.sql.tests.shared.assertEquals
+import org.junit.Test
+
+class `Table id not in Record Test issue 1341` : DatabaseTestsBase() {
+
+    object NamesTable : IdTable<Int>("names_table") {
+        val first = varchar("first", 50)
+
+        val second = varchar("second", 50)
+
+        override val id = integer("id").autoIncrement().entityId()
+
+        override val primaryKey = PrimaryKey(id)
+    }
+
+    object AccountsTable : IdTable<Int>("accounts_table") {
+        val name = reference("name", NamesTable)
+        override val id: Column<EntityID<Int>> = integer("id").autoIncrement().entityId()
+        override val primaryKey = PrimaryKey(id)
+    }
+
+    class Names(id: EntityID<Int>) : IntEntity(id) {
+        var first: String by NamesTable.first
+        var second: String by NamesTable.second
+        companion object : IntEntityClass<Names>(NamesTable)
+    }
+
+    class Accounts(id: EntityID<Int>) : IntEntity(id) {
+        var name: Names by Names referencedOn AccountsTable.name
+
+        companion object : EntityClass<Int, Accounts>(AccountsTable) {
+            fun new(accountName: Pair<String, String>): Accounts = new {
+                this.name = Names.new {
+                    first = accountName.first
+                    second = accountName.second
+                }
+            }
+        }
+    }
+
+    @Test
+    fun testRegression() {
+        withTables(NamesTable, AccountsTable) {
+            val account = Accounts.new("first" to "second")
+            assertEquals("first", account.name.first)
+            assertEquals("second", account.name.second)
+        }
+    }
+}