Ensure a stable composer release is used #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer recommend we use composer-stable.phar for stable versions, not composer.phar.
Composer recommend we use composer-stable for a stable release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Composer runner is downloading the snapshot release of composer. Should it not be using the stable release?
Currently Composer is on version 1.x but 2.x is being worked on.
Using the snapshot version means that composer will rely on unstable dependencies, i.e. composer-plugin-api. When building a project on the current composer 1.x it will build using composer-plugin-api 1.x. When this runner is used it will use composer-plugin-api 2.x which is unstable, and will likely fail as other stable plugins are not be compatible.
This PR ensures a stable composer is downloaded.
See the Composer download page here: https://getcomposer.org/download/
Thx