Fix Modules API when using Identifiers #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Unreported bug: Modules API would inadvertently report data or act on all modules with a matching name, even when using an module identifier as the parameter.
This PR corrects this behavior to the expected behavior of only acting on the module matching the unique identifier.
Steps to reproduce
Given multiple instances of module (e.g. calendar). Calling http://localhost:8080/api/module/module_5_calendar would return data for all calendar modules instead of just instance 5. This also caused hide/show actions to fail to act on the expected module.
Additional info