Remove readr from dependencies #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage seems entirely redundant. You are taking a character vector and passing it as literal data to `read_lines()` which returns the same character vector as the input. The current example breaks with readr 2.0.0 as literal data needs to be denoted with `I()` in readr 2.0.0, but as far as I can tell readr should just be removed entirely. In addition the genius website layout seems to have changed, the lyrics are no longer being retrieved with either the CRAN version or this change.
|
Thanks, Jim! I wrote this a long time ago and my skills were...not where they are today. I'll give this a look. Much appreciated. |
|
Note to self: new class is |
|
Addressed. Thank you for letting me know about the broken functions as well. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage seems entirely redundant. You are taking a character vector
and passing it as literal data to
read_lines()which returns the samecharacter vector as the input.
The current example breaks with readr 2.0.0 as literal data needs to be
denoted with
I()in readr 2.0.0, but as far as I can tell readr shouldjust be removed entirely.
In addition the genius website layout seems to have changed, the lyrics
are no longer being retrieved with either the CRAN version or this
change.