Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Base.dataids(::BlockArray)
was callingobjectid
which was rather slow:This patch also makes alias detection slightly stronger for block arrays. But I then noticed that block arrays can't have proper
dataids
because the number of "data arrays" can't be determined by the type parameters (if we try to make it precise,dataids
cannot be inferred and also it's not O(1) function anymore).FYI we are trying to improve alias detection in
Base
. The discussion in Julia repo is not super relevant to this issue. But I wonder this should be taken into account if we were to redesign it inBase
: JuliaLang/julia#29546