-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show type for IdOffsetRange #143
Conversation
This PR alleviates this issue in #120 : Previously julia> @test 1:3 === OffsetArrays.IdOffsetRange(1:3)
Test Failed at none:1
Expression: 1:3 === OffsetArrays.IdOffsetRange(1:3)
Evaluated: 1:3 === 1:3
ERROR: There was an error during testing Now julia> @test 1:3 === OffsetArrays.IdOffsetRange(1:3)
Test Failed at REPL[12]:1
Expression: 1:3 === OffsetArrays.IdOffsetRange(1:3)
Evaluated: 1:3 === OffsetArrays.IdOffsetRange(1:3)
ERROR: There was an error during testing |
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 90.49% 93.33% +2.83%
==========================================
Files 2 2
Lines 221 240 +19
==========================================
+ Hits 200 224 +24
+ Misses 21 16 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I was planning to fix these after finishing my little DemoCards project but you certainly did a great job here!
Could possibly add some show tests to capture the patterns as a regression test. The tools I'd personally use isSuppressor.@capture
, or ReferenceTests
's @io2str
/@test_reference
.
You're doing great here, feel free to merge if you think it is ready.
* Add constructors for CartesianIndices. A combination of `AbstractUnitRange`s, `Colon` and `CartesianIndices` may be provided to the constructor such that the total number of ranges is equal to the dimension of the parent array. * Use `convert` instead of accessing indices, leads to the same lowered code but is future-proof
…Arrays.jl into showIdOffsetRange
FYI you could use |
I think we need to update the docs to reflect this change |
This PR attempts to fix #121 . Now we have