deprecate the roundmode method for centered
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 5 5
Lines 436 436
=======================================
Hits 416 416
Misses 20 20
Continue to review full report at Codecov.
|
johnnychen94
force-pushed
the
jc/centered_fix
branch
from
befa7f8 to
bb1300d
Compare
|
I see no reasons to wait for this, so I'm merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was really a design mistake and I still can't believe I ignored that obvious conflict especially I did write a test case for it. 😢
The new
cpmethod is quite trivial, but I feel it's conceptually as meaningful asOffsetArrays.Origin.fixes #250