Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the roundmode method for centered #251

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Aug 2, 2021

This was really a design mistake and I still can't believe I ignored that obvious conflict especially I did write a test case for it. 😢

The new cp method is quite trivial, but I feel it's conceptually as meaningful as OffsetArrays.Origin.

fixes #250

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #251 (bb1300d) into master (2a678a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files           5        5           
  Lines         436      436           
=======================================
  Hits          416      416           
  Misses         20       20           
Impacted Files Coverage Δ
src/OffsetArrays.jl 98.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a678a7...bb1300d. Read the comment docs.

@johnnychen94
Copy link
Member Author

I see no reasons to wait for this, so I'm merging now.

@johnnychen94 johnnychen94 merged commit 62af376 into master Aug 4, 2021
@johnnychen94 johnnychen94 deleted the jc/centered_fix branch August 4, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter intuitive result in centered with rounding modes specified
1 participant