Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow AbstractString in various interfaces #190

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

xitology
Copy link
Contributor

While fixing #189, I went on and updated all the other methods that were restricted to String. In particular, an AbstractString value can now be used as

  • a connection parameter or an option value;
  • a SQL query;
  • an input parameter;
  • a string literal in MySQL.escape.

If you think this is too much, I could make a smaller patch that only addresses #189.

In particular, an AbstractString value can now be used as

- a connection parameter or an option value;
- a SQL statement;
- an input parameter;
- a string literal to escape.
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #190 (cd0facc) into main (c514ff6) will increase coverage by 0.93%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   63.37%   64.31%   +0.93%     
==========================================
  Files           9        9              
  Lines        1103     1104       +1     
==========================================
+ Hits          699      710      +11     
+ Misses        404      394      -10     
Impacted Files Coverage Δ
src/api/ccalls.jl 20.68% <0.00%> (+0.49%) ⬆️
src/api/capi.jl 33.14% <30.00%> (+4.00%) ⬆️
src/api/papi.jl 43.54% <50.00%> (ø)
src/MySQL.jl 68.65% <100.00%> (+1.49%) ⬆️
src/prepare.jl 98.29% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c514ff6...cd0facc. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xitology; this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants