allow AbstractString in various interfaces #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, an AbstractString value can now be used as - a connection parameter or an option value; - a SQL statement; - an input parameter; - a string literal to escape.
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 63.37% 64.31% +0.93%
==========================================
Files 9 9
Lines 1103 1104 +1
==========================================
+ Hits 699 710 +11
+ Misses 404 394 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #189, I went on and updated all the other methods that were restricted to
String. In particular, an AbstractString value can now be used asMySQL.escape.If you think this is too much, I could make a smaller patch that only addresses #189.