Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BroadcastStyle of Differentials needs to match their primals #94

Open
oxinabox opened this issue Jan 13, 2020 · 1 comment
Open

BroadcastStyle of Differentials needs to match their primals #94

oxinabox opened this issue Jan 13, 2020 · 1 comment

Comments

@oxinabox
Copy link
Member

Particularlyatyers for Composite of subtypes of AbstractArray

For Thunks we need to unthunk at start, by overloading broadcasted

@oxinabox
Copy link
Member Author

Yay, BroadcastStyle is a proper trait - it depends only on type.
And since the Composite differential is type-parametric on it’s primal type. Making them broadcast the same is trivial.
So Composite{<:AbstactArray} will work as well as a AbstractArray of differentials .
This is really pleasing.
This directly matters for #85

More generally this issue relates to #92 since operations between single deriviatives and chunked dervatives are broadcasting.

Also #96 is related in that it covers the cases not mentioned in the top of this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant