Make thunked unthunk before broadcasting #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @testset "Broadcast" begin | ||
| @testset "Array" begin | ||
| was_unthunked = 0 |
There was a problem hiding this comment.
this line's not needed?
Suggested change
| was_unthunked = 0 |
There was a problem hiding this comment.
I feel weird about using variables in closures before they are declared.
There was a problem hiding this comment.
do you think it is better to remove it?
There was a problem hiding this comment.
Yes, but the dont really mind too much either way
| end | ||
|
|
||
| @testset "Scalar" begin | ||
| was_unthunked=0 |
There was a problem hiding this comment.
Suggested change
| was_unthunked=0 |
Co-Authored-By: Nick Robinson <[email protected]>
nickrobinson251
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it
externed.I didn't know it did that either, so was surprised tests passed.
This is part of #94