-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error inside Tangent
constructor if incorrect backing type is used
#495
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
address my comments as you will, and make sure CI is passing. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hmm, actually - what should we do about |
Yes. |
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 92.94% 92.90% -0.04%
==========================================
Files 15 15
Lines 822 818 -4
==========================================
- Hits 764 760 -4
Misses 58 58
Continue to review full report at Codecov.
|
Diffractor (same failure on its master) and Julia nightly (test unexpectedly passes) errors look unrelated. Will merge if ChainRules tests pass |
Co-authored-by: Lyndon White <[email protected]>
This broke Diffractor. Is this really worth it? |
It could be written out using dispatch instead of if statements, maybe that would help? |
No, that's not the problem. Diffractor uses tuple backing for tangents of tangents over tuples. This could probably be changed at some point, but I don't think this should have been merged without any discussion now that we have the integration test. |
Hmm I am not sure that it should. But for now maybe let's revert this PR, and then we can think about it.
Ah sorry, I think we just got used to Diffractor being broken. Yes, this was bad. |
Just for the future: Could you please always squash merge commits like these before merging? It's just such a pain to revert otherwise. (Edit: Turns out it's not that bad if you are working off the correct branch 🤦. Squash merges are still pretty much always easier to work with though, so my point still stands.) I wonder whether we should just disallow anything except squash merge for this repo. |
Hey Simeon, sorry about breaking Diffractor. The error looked unrelated and was the same one as on master at the time, so I didn't think there was anything wrong with the PR. And yes, will make sure to merge next time.
Are there any reasons why a NamedTuple, e.g. |
I'm pretty sure that's possible, but it's not super trivial because that assumption is used in multiple places. Once I have figured that out, we should be able to relate this. |
This is JuliaDiff/Diffractor.jl#67, BTW. |
Closes #494. Might need to fix things downstream if incorrect types are used.