Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integrate for several variables and add simple tests #149

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

dpsanders
Copy link
Contributor

Fixes #146.

@coveralls
Copy link

coveralls commented Feb 20, 2018

Coverage Status

Coverage decreased (-0.002%) to 97.183% when pulling 237632b on fix_integrate into 4a1eed0 on master.

@dpsanders
Copy link
Contributor Author

Tests pass on 0.6.
Something is going wrong with allowing failures on 0.7.

Shall we merge anyway?

@dpsanders
Copy link
Contributor Author

Apparently I didn't have latest master with latest .travis.yml.
Have now rebased against latest master which should hopefully fix the problem.

@dpsanders
Copy link
Contributor Author

@lbenet This is ready to merge.

@lbenet
Copy link
Member

lbenet commented Feb 21, 2018

Thanks a lot! I'll merge this!

@lbenet lbenet merged commit c6b45d2 into master Feb 21, 2018
@lbenet
Copy link
Member

lbenet commented Feb 21, 2018

Incidentally, the problem with some tests for Julia 0.7 seems to be related to the need of loading certain parts which in 0.7 are the stdlib. I have done already something on this, without caring about 0.6 compatibility; see the branch deprecations0.7.

@lbenet lbenet deleted the fix_integrate branch March 25, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants