Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reduce_empty(::AdjoinIdentity, ::Type) #64

Merged
merged 4 commits into from
Dec 24, 2021

Conversation

ChrisRackauckas
Copy link
Contributor

@ChrisRackauckas ChrisRackauckas commented Dec 24, 2021

close #63

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #64 (6fb168c) into master (43d4a28) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   93.44%   93.22%   -0.23%     
==========================================
  Files           2        2              
  Lines          61       59       -2     
==========================================
- Hits           57       55       -2     
  Misses          4        4              
Flag Coverage Δ
unittests 93.22% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InitialValues.jl 90.69% <ø> (-0.22%) ⬇️
src/prettyexpr.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d4a28...6fb168c. Read the comment docs.

@tkf
Copy link
Member

tkf commented Dec 24, 2021

The failure from Pkg.test can be ignored since it is due to that BangBang supporting this is not available.

@tkf tkf changed the title Try removing invalidating method Remove reduce_empty(::AdjoinIdentity, ::Type) Dec 24, 2021
@tkf tkf merged commit 4e401ff into JuliaFolds:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidations issues
2 participants