Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCN compiler target #2

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Add GCN compiler target #2

merged 2 commits into from
Apr 23, 2020

Conversation

jpsamaroo
Copy link
Member

AMDGPUnative PR to follow

@jpsamaroo
Copy link
Member Author

The first two commits are from #1

@jpsamaroo jpsamaroo changed the title Add AMDGPU stub [WIP] Add AMDGPU stub Apr 9, 2020
@jpsamaroo
Copy link
Member Author

AMDGPUnative PR: JuliaGPU/AMDGPUnative.jl#46

@jpsamaroo jpsamaroo force-pushed the jps/amdgpu branch 2 times, most recently from 37ec92a to 9f07624 Compare April 12, 2020 16:51
@maleadt
Copy link
Member

maleadt commented Apr 14, 2020

Rebased. Would be good to add some local tests + reverse CI.

maleadt
maleadt reviewed Apr 14, 2020
View reviewed changes
@jpsamaroo
Copy link
Member Author

jpsamaroo commented Apr 15, 2020 •
edited
Loading

@maleadt aside from the 1.4/nightly failures, there are two broken testsets that I've marked. The invalid addrspacecast failure is expected (to/from Julia's addrspaces), the other I don't recognize.

@maleadt
Copy link
Member

maleadt commented Apr 15, 2020 •
edited
Loading

Looking at the segfault, I suspected a violated LLVM assertion, so I added a CI build for that:

 julia: /workspace/srcdir/llvm-project/llvm/lib/IR/Instructions.cpp:3262: llvm::BitCastInst::BitCastInst(llvm::Value*, llvm::Type*, const llvm::Twine&, llvm::Instruction*): Assertion `castIsValid(getOpcode(), S, Ty) && "Illegal BitCast"' failed.

@maleadt
Copy link
Member

maleadt commented Apr 15, 2020

For tests that are only broken on 1.4, you can import and use @test_broken_if from https://github.com/JuliaGPU/CUDAnative.jl/blob/7b8973371edea0b04900cbb086e9ad35d189db4c/test/util.jl#L105-L114

@maleadt maleadt mentioned this pull request Apr 21, 2020
Merged
@jpsamaroo jpsamaroo changed the title [WIP] Add AMDGPU stub Add AMDGPU stub Apr 23, 2020
@jpsamaroo jpsamaroo changed the title Add AMDGPU stub Add GCN stub Apr 23, 2020
@jpsamaroo
Add GCN compiler target
57218b8 
Add GCN tests and reverse CI
Remove extra error calls
@jpsamaroo jpsamaroo changed the title Add GCN stub Add GCN compiler target Apr 23, 2020
@jpsamaroo jpsamaroo merged commit bcdf3e4 into master Apr 23, 2020
@maleadt maleadt deleted the jps/amdgpu branch March 9, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpsamaroo @maleadt