-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate exit/trap with noreturn & inaccessiblememonly #359
Conversation
b0af98a
to
dd1a88d
Compare
Codecov ReportBase: 86.71% // Head: 86.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 86.71% 86.78% +0.06%
==========================================
Files 24 24
Lines 2801 2808 +7
==========================================
+ Hits 2429 2437 +8
+ Misses 372 371 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These attributes are probably incompatible with AMDGPU's exception handling infrastructure, which does a variety of things like accessing a shared hostcall buffer, accessing locks in local (shared) memory, and soon many more things as make enhancements. We should probably add an interface function to check if the target's exception handling functions can be given these attributes. |
This should help Enzyme to not assume that this assembly has
any effects it needs to handle.