Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interactive reflection for KernelError #383

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

jpsamaroo
Copy link
Member

So that we can use Cthulhu to debug kernels which always throw (return Union{}).

@jpsamaroo jpsamaroo added the enhancement New feature or request label Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 87.21% // Head: 87.01% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (1db5bc3) compared to base (9ed49c6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   87.21%   87.01%   -0.20%     
==========================================
  Files          24       24              
  Lines        2839     2842       +3     
==========================================
- Hits         2476     2473       -3     
- Misses        363      369       +6     
Impacted Files Coverage Δ
src/reflection.jl 76.22% <0.00%> (-1.64%) ⬇️
src/jlgen.jl 81.28% <0.00%> (-1.98%) ⬇️
src/debug.jl 97.22% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpsamaroo jpsamaroo merged commit 111d652 into master Jan 13, 2023
@jpsamaroo jpsamaroo deleted the jps/kernelerror-cthulhu branch January 13, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant