Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid OOB linetable access on pre-1.5. #40

Merged
merged 2 commits into from
May 29, 2020
Merged

Avoid OOB linetable access on pre-1.5. #40

merged 2 commits into from
May 29, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 28, 2020

I think this was the cause for nonsensical stack traces like:

 Error During Test at /builds/JuliaGPU/CUDA.jl/test/device/cuda.jl:907
  Got exception outside of a @test
  CUDA error: out of memory (code 2, ERROR_OUT_OF_MEMORY)
  Stacktrace:
   [1] throw_api_error(::CUDA.cudaError_enum) at /builds/JuliaGPU/CUDA.jl/lib/cuda/error.jl:103
   [2] CuModule(::Array{UInt8,1}, ::Dict{CUDA.CUjit_option_enum,Any}) at /builds/JuliaGPU/CUDA.jl/lib/cuda/module.jl:42
   [3] CuModule(::CuLinkImage, ::Dict{CUDA.CUjit_option_enum,Any}) at /builds/JuliaGPU/CUDA.jl/lib/cuda/module/linker.jl:142
   [4] _cufunction(::GPUCompiler.FunctionSpec{var"#3908#kernel#593",Tuple{}}; kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /builds/JuliaGPU/CUDA.jl/src/compiler/execution.jl:335
   [5] _cufunction at /builds/JuliaGPU/CUDA.jl/src/compiler/execution.jl:302 [inlined]
   [6] #75 at /builds/JuliaGPU/CUDA.jl/.julia/packages/GPUCompiler/lqbF2/src/cache.jl:21 [inlined]
   [7] get!(::GPUCompiler.var"#75#76"{Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}},typeof(CUDA._cufunction),GPUCompiler.FunctionSpec{var"#3908#kernel#593",Tuple{}}}, ::Dict{UInt64,Any}, ::UInt64) at ./dict.jl:452
   [8] macro expansion at ./lock.jl:183 [inlined]
   [9] check_cache(::typeof(CUDA._cufunction), ::GPUCompiler.FunctionSpec{var"#3908#kernel#593",Tuple{}}, ::UInt64; kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /builds/JuliaGPU/CUDA.jl/.julia/packages/GPUCompiler/lqbF2/src/cache.jl:19
   [10] + at ./int.jl:53 [inlined]
   [11] hash_64_64 at ./hashing.jl:35 [inlined]
   [12] hash_uint64 at ./hashing.jl:62 [inlined]
   [13] hx at ./float.jl:568 [inlined]
   [14] hash at ./float.jl:571 [inlined]
   [15] cached_compilation(::typeof(CUDA._cufunction), ::GPUCompiler.FunctionSpec{var"#3908#kernel#593",Tuple{}}, ::UInt64; kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /builds/JuliaGPU/CUDA.jl/.julia/packages/GPUCompiler/lqbF2/src/cache.jl:0
   [16] cached_compilation(::Function, ::GPUCompiler.FunctionSpec{var"#3908#kernel#593",Tuple{}}, ::UInt64) at /builds/JuliaGPU/CUDA.jl/.julia/packages/GPUCompiler/lqbF2/src/cache.jl:37
   [17] cufunction(::Function, ::Type; name::Nothing, kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /builds/JuliaGPU/CUDA.jl/src/compiler/execution.jl:296
   [18] cufunction(::Function, ::Type{T} where T) at /builds/JuliaGPU/CUDA.jl/src/compiler/execution.jl:291
   [19] top-level scope at /builds/JuliaGPU/CUDA.jl/src/compiler/execution.jl:108
   [20] top-level scope at /builds/JuliaGPU/CUDA.jl/test/device/cuda.jl:909
   [21] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Test/src/Test.jl:1113
   [22] top-level scope at /builds/JuliaGPU/CUDA.jl/test/device/cuda.jl:908
   [23] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Test/src/Test.jl:1113
   [24] top-level scope at /builds/JuliaGPU/CUDA.jl/test/device/cuda.jl:5
   [25] include(::String) at ./client.jl:439
   [26] #11 at /builds/JuliaGPU/CUDA.jl/test/runtests.jl:73 [inlined]
   [27] macro expansion at /builds/JuliaGPU/CUDA.jl/test/setup.jl:43 [inlined]
   [28] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Test/src/Test.jl:1113 [inlined]
   [29] macro expansion at /builds/JuliaGPU/CUDA.jl/test/setup.jl:43 [inlined]
   [30] macro expansion at /builds/JuliaGPU/CUDA.jl/src/utilities.jl:14 [inlined]
   [31] macro expansion at /builds/JuliaGPU/CUDA.jl/src/memory.jl:415 [inlined]
   [32] top-level scope at /builds/JuliaGPU/CUDA.jl/test/setup.jl:42
   [33] eval at ./boot.jl:331 [inlined]
   [34] runtests(::Function, ::String, ::CuDevice, ::Nothing) at /builds/JuliaGPU/CUDA.jl/test/setup.jl:53
   [35] (::Distributed.var"#104#106"{Distributed.CallMsg{:call_fetch}})() at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Distributed/src/process_messages.jl:294
   [36] run_work_thunk(::Distributed.var"#104#106"{Distributed.CallMsg{:call_fetch}}, ::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Distributed/src/process_messages.jl:79
   [37] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Distributed/src/process_messages.jl:294 [inlined]
   [38] (::Distributed.var"#103#105"{Distributed.CallMsg{:call_fetch},Distributed.MsgHeader,Sockets.TCPSocket})() at ./task.jl:358

@maleadt maleadt force-pushed the tb/linetable_oob branch from 3e652a6 to 8fe5f9e Compare May 29, 2020 08:13
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #40 into master will decrease coverage by 8.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   68.83%   60.71%   -8.13%     
==========================================
  Files          18       25       +7     
  Lines        1120     1423     +303     
==========================================
+ Hits          771      864      +93     
- Misses        349      559     +210     
Impacted Files Coverage Δ
src/cache.jl 0.00% <0.00%> (ø)
src/gcn.jl 0.00% <0.00%> (ø)
test/definitions/gcn.jl 0.00% <0.00%> (ø)
test/ptx.jl 36.36% <0.00%> (ø)
test/native.jl 37.50% <0.00%> (ø)
test/gcn.jl 0.00% <0.00%> (ø)
test/definitions/native.jl 100.00% <0.00%> (ø)
test/definitions/ptx.jl 83.33% <0.00%> (ø)
test/util.jl 33.33% <0.00%> (ø)
src/ptx.jl 90.38% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f717de4...8fe5f9e. Read the comment docs.

@maleadt maleadt merged commit bb8bdf4 into master May 29, 2020
@maleadt maleadt deleted the tb/linetable_oob branch May 29, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant