Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test suite after Cthulhu.jl update. #400

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Fix test suite after Cthulhu.jl update. #400

merged 1 commit into from
Mar 11, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Mar 10, 2023

This was changed in JuliaDebug/Cthulhu.jl#356

@maleadt maleadt requested a review from vchuravy March 10, 2023 15:04
@maleadt maleadt marked this pull request as ready for review March 10, 2023 15:04
@vchuravy
Copy link
Member

vchuravy commented Mar 10, 2023 •
edited
Loading

cc: @timholy for your info,

@timholy
Copy link
Member

timholy commented Mar 10, 2023

Thanks. Hopefully doesn't count as a breaking change since it's in a test module. But nice to know, thanks for CCing me.

@maleadt
Copy link
Member Author

maleadt commented Mar 10, 2023

Hopefully doesn't count as a breaking change since it's in a test module.

Yeah no worries.

The hang does seem reproducible though, on 1.9-rc1 the call to cread(out) hangs. @vchuravy mind taking a look?

@timholy
Copy link
Member

timholy commented Mar 10, 2023

Come to think of it, you probably need to pass annotate_source=false as a kwarg to GPUCompiler.code_typed.

@maleadt maleadt force-pushed the tb/cthulhu_fake_terminals branch from 1298529 to 31a07df Compare March 10, 2023 20:00
@timholy
Copy link
Member

timholy commented Mar 10, 2023

You may also want to make Cthulhu 2.8 the minimum version in the [compat] because that's the first version that supports this kwarg.

@timholy
Copy link
Member

timholy commented Mar 10, 2023

Glad to see that fixed it!

@maleadt
Copy link
Member Author

maleadt commented Mar 11, 2023

Thanks!

@maleadt maleadt merged commit e83b2db into master Mar 11, 2023
@maleadt maleadt deleted the tb/cthulhu_fake_terminals branch March 11, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy approved these changes

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maleadt @vchuravy @timholy