Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt handling of world ages to upstream changes #403

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Mar 13, 2023

Adapts to JuliaLang/julia#48611.
Helps towards #146, but doesn't fix it yet.
Ref #394

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 85.05% and project coverage change: +1.55 🎉

Comparison is base (7e0a6ff) 78.74% compared to head (6be6ee6) 80.29%.

❗ Current head 6be6ee6 differs from pull request most recent head 33728eb. Consider uploading reports for the commit 33728eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   78.74%   80.29%   +1.55%     
==========================================
  Files          24       24              
  Lines        2856     2888      +32     
==========================================
+ Hits         2249     2319      +70     
+ Misses        607      569      -38     
Impacted Files Coverage Δ
src/jlgen.jl 80.62% <80.86%> (+8.60%) ⬆️
src/reflection.jl 36.43% <83.33%> (+1.04%) ⬆️
src/driver.jl 92.09% <84.00%> (+0.63%) ⬆️
src/irgen.jl 87.97% <95.45%> (+1.51%) ⬆️
src/cache.jl 96.15% <100.00%> (+3.96%) ⬆️
src/interface.jl 80.95% <100.00%> (+3.17%) ⬆️
src/rtlib.jl 96.20% <100.00%> (ø)
src/validation.jl 97.33% <100.00%> (+4.00%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt marked this pull request as ready for review March 29, 2023 08:40
@maleadt maleadt force-pushed the tb/world_ages_bis branch from 328a400 to 33728eb Compare March 29, 2023 13:06
@oscardssmith
Copy link

Should this be merged? GPUCompiler is failing on julia nightly due to the lack of this.

@maleadt
Copy link
Member Author

maleadt commented Mar 30, 2023

I'm still working in some improvements, but I'll be sure to merge and tag this today to unblock that part of the stack.

@maleadt maleadt force-pushed the tb/world_ages_bis branch 2 times, most recently from 96bfe96 to 6be6ee6 Compare March 30, 2023 12:23
@maleadt maleadt changed the title Adapt handling of world ages to upstream changes. Adapt handling of world ages to upstream changes Mar 30, 2023
@maleadt maleadt force-pushed the tb/world_ages_bis branch from 6be6ee6 to 33728eb Compare March 30, 2023 12:57
@maleadt maleadt merged commit 94085d0 into master Mar 30, 2023
@maleadt maleadt deleted the tb/world_ages_bis branch March 30, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants