Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt NVVMReflect pass to LLVM.jl changes. #411

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Adapt NVVMReflect pass to LLVM.jl changes. #411

merged 2 commits into from
Mar 21, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Mar 21, 2023

Fixes #410.

Normally I'd revert such a breaking change in LLVM.jl, but we were incorrectly representing the LLVM type hierarchy before, so I'll create backport releases fixing GPUCompiler.jl instead.

@maleadt maleadt added the ptx Stuff about the NVIDIA PTX back-end. label Mar 21, 2023
@maleadt
Copy link
Member Author

maleadt commented Mar 21, 2023

Hmm, we've been using LLVM 4.x for ages, so this would take many backports.

Alternative proposal: I'll revert the change on LLVM.jl, and put it in a breaking release instead. That may be useful anyway to deal with the upcoming opaque pointer changes.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -5.88 ⚠️

Comparison is base (bec672c) 85.85% compared to head (b4e891d) 79.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   85.85%   79.97%   -5.88%     
==========================================
  Files          24       24              
  Lines        2871     2857      -14     
==========================================
- Hits         2465     2285     -180     
- Misses        406      572     +166     
Impacted Files Coverage Δ
src/ptx.jl 67.40% <0.00%> (-17.63%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 7e0a6ff into master Mar 21, 2023
@maleadt maleadt deleted the tb/nvvm_reflect branch March 21, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ptx Stuff about the NVIDIA PTX back-end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM upgrade broke NVVMReflect pass
1 participant