Adapt NVVMReflect pass to LLVM.jl changes. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, we've been using LLVM 4.x for ages, so this would take many backports. Alternative proposal: I'll revert the change on LLVM.jl, and put it in a breaking release instead. That may be useful anyway to deal with the upcoming opaque pointer changes. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 85.85% 79.97% -5.88%
==========================================
Files 24 24
Lines 2871 2857 -14
==========================================
- Hits 2465 2285 -180
- Misses 406 572 +166
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410.
Normally I'd revert such a breaking change in LLVM.jl, but we were incorrectly representing the LLVM type hierarchy before, so I'll create backport releases fixing GPUCompiler.jl instead.