Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop prefix from explicitly set entrypoint #423

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

Seelengrab
Copy link
Contributor

This depends on #422 due to changing the same line in irgen.jl.

Opening as a draft until #422 is closed.

@maleadt
Copy link
Member

maleadt commented Apr 4, 2023

I was actually considering dropping the prefix altogether. If you choose a custom name for the entrypoint, it shouldn't be prefixed by anything, no?

@Seelengrab
Copy link
Contributor Author

Seelengrab commented Apr 4, 2023

Yeah, that makes sense too - I'll change it to drop the prefix entirely if entry_name is set (if that is still what you want to call it due to #422). I originally thought the prefix could be used for every function, not just the entry point.

@Seelengrab Seelengrab force-pushed the prefix_configuration branch from f56dbb4 to 64121d7 Compare April 4, 2023 11:09
@Seelengrab Seelengrab marked this pull request as ready for review April 4, 2023 11:10
@Seelengrab
Copy link
Contributor Author

Right, this is now disentangled from #422, so if tests run through this should be mergeable.

@Seelengrab Seelengrab changed the title Allow Prefix configuration for entrypoint Drop prefix from entrypoint Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.68 ⚠️

Comparison is base (f793923) 86.92% compared to head (64121d7) 80.24%.

❗ Current head 64121d7 differs from pull request most recent head 94e179b. Consider uploading reports for the commit 94e179b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   86.92%   80.24%   -6.68%     
==========================================
  Files          24       24              
  Lines        2922     2896      -26     
==========================================
- Hits         2540     2324     -216     
- Misses        382      572     +190     
Impacted Files Coverage Δ
src/irgen.jl 85.28% <0.00%> (-9.17%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Seelengrab Seelengrab changed the title Drop prefix from entrypoint Drop prefix from explicitly set entrypoint Apr 4, 2023
@Seelengrab
Copy link
Contributor Author

And backports failed again, for the same reason as before..

Checking this PR locally, seems like naming the function main or start is not enough to have it emitted as the first function at address 0x0 :/ Still a good change I think, but doesn't fix the issue I was experiencing..

@maleadt maleadt merged commit a203f04 into JuliaGPU:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants