Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalidations of safe logging functionality by custom loggers. #432

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Apr 19, 2023

Fixes #431

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7c4855e) 87.13% compared to head (9a2f103) 87.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files          24       24           
  Lines        2939     2941    +2     
=======================================
+ Hits         2561     2563    +2     
  Misses        378      378           
Impacted Files Coverage Δ
src/utils.jl 97.95% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 7a45af6 into master Apr 19, 2023
@maleadt maleadt deleted the tb/custom_loggers branch April 19, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min_enabled_level is at risk of invalidations
1 participant