Improvements for Metal #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
==========================================
- Coverage 86.71% 86.29% -0.42%
==========================================
Files 23 23
Lines 2943 2970 +27
==========================================
+ Hits 2552 2563 +11
- Misses 391 407 +16
☔ View full report in Codecov by Sentry. |
maleadt
changed the title
maleadt
force-pushed
the
tb/metal_version
branch
from
e0937d3 to
b850847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were also always using Metal 2.4.0, even on macOS 13 (while using Metal 3-only features)... Not sure why that did work. I'm also not sure what the difference is between the Metal and AIR version; we emit the same version for both.