Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse opaque closures. #447

Merged
merged 1 commit into from
May 11, 2023
Merged

Refuse opaque closures. #447

merged 1 commit into from
May 11, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 11, 2023

These are objects containing a CPU pointer. They would also fail the mutability check below, but let's be a little more verbose.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -1.25 ⚠️

Comparison is base (5de5a5c) 87.06% compared to head (ac74605) 85.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   87.06%   85.81%   -1.25%     
==========================================
  Files          24       24              
  Lines        2961     2954       -7     
==========================================
- Hits         2578     2535      -43     
- Misses        383      419      +36     
Impacted Files Coverage Δ
src/validation.jl 96.27% <33.33%> (-1.20%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit a29682a into master May 11, 2023
@maleadt maleadt deleted the tb/oc branch May 11, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant