Optimize the execution macro helper functionality. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generators and closures in there causes unnecessary recompilation during at-cuda lowering.
maleadt
force-pushed
the
tb/optimize_macro_helpers
branch
from
933c25c to
4edcc7e
Compare
maleadt
force-pushed
the
tb/optimize_macro_helpers
branch
from
4edcc7e to
1f96fe1
Compare
|
@maleadt yeah it was broken for the past 18 hours but has been since fixed by EnzymeAD/Enzyme.jl#843 so you shouldn't need to allow Enzyme to fail anymore. |
|
Great, thanks! |
maleadt
force-pushed
the
tb/optimize_macro_helpers
branch
from
1f96fe1 to
6011d6c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 85.64% 85.71% +0.07%
==========================================
Files 24 24
Lines 2954 2962 +8
==========================================
+ Hits 2530 2539 +9
+ Misses 424 423 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generators and closures in there causes unnecessary recompilation during at-cuda lowering.